Open johnkerl opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.65%. Comparing base (
4e3b70f
) to head (8c5f857
). Report is 1 commits behind head on main.
From the build log:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/__w/TileDB-SOMA/TileDB-SOMA/venv-soma/lib/python3.10/site-packages/tiledbsoma/__init__.py", line 103, in <module>
from ._collection import Collection
File "/__w/TileDB-SOMA/TileDB-SOMA/venv-soma/lib/python3.10/site-packages/tiledbsoma/_collection.py", line 3[7](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10895777089/job/30234556256#step:18:8), in <module>
from ._dataframe import DataFrame
File "/__w/TileDB-SOMA/TileDB-SOMA/venv-soma/lib/python3.10/site-packages/tiledbsoma/_dataframe.py", line 17, in <module>
from tiledbsoma import _new_shape_feature_flag_enabled
ImportError: cannot import name '_new_shape_feature_flag_enabled' from partially initialized module 'tiledbsoma' (most likely due to a circular import) (/__w/TileDB-SOMA/TileDB-SOMA/venv-soma/lib/python3.[10](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10895777089/job/30234556256#step:18:11)/site-packages/tiledbsoma/__init__.py)
This is because at the point this line is executed, the symbol _new_shape_feature_flag_enabled
is not yet available. The line
needs to be moved above all the imports. (Alternately, it might make sense to create a tiledbsoma._flags
module so that there’s no circular dependency between submodules and the tiledbsoma/__init__.py
file.
needs to be moved above all the imports
@thetorpedodog thank you!!! I got some 'new style lint' here -- I don't know why, I didn't change any linter versions -- and was forced to move imports :(
There's something weird to debug here -- I'll see if I can make everything in the CI toolchain happy simultaneously -- thank you!!!
Also I'll try the _flags
module idea -- this sounds promising -- thank you! :)
@thetorpedodog
And re
There's something weird to debug here -- I'll see if I can make everything in the CI toolchain happy simultaneously -- thank you!!!
I have traced that to here:
https://github.com/single-cell-data/TileDB-SOMA/pull/3004/files#r1763424424
Hi guys, thanks for your amazing package.
I understand this is in flux as we write - as a power user I would kindly like to ask if there's anything I can do to help push this through - I really need it and workarounds are a decent pain.
(As I understand, now there is a buggy typechecker stalling CI stalling 3.12 adoption, which itself was released 12 months ago. If inaccurate feel free to correct)
@iosonofabio thank you! Your assessment is correct -- current status is here: https://github.com/single-cell-data/TileDB-SOMA/issues/1849#issuecomment-2358420564 and @ryan-williams will be moving this forward
For issue #1849 -- which has a long history.
See also #2999 and [sc-53002].
This needs https://github.com/single-cell-data/SOMA/pull/222