search

single-cell-genetics / cardelino

Clone identification from single-cell data
59 stars 12 forks source link

Bug report: clone_id and cell_assign_Gibbs #47

Closed yilinzhao1615 closed 1 year ago

yilinzhao1615 commented 1 year ago

Hi,

I am running into an error when using clone_id.

assignments <- cardelino::clone_id(input_data$A, input_data$D, Config=config.tree, inference = "sampling")

Input A and D have the same dimension.

The error message: Error in { : task 1 failed - "new columns would leave holes after existing columns"

After debugging, I think it might be caused by the cell_assign_Gibbs(0.4.2 release)/clone_id_Gibbs(in the main branch) function. 

A[which(D == 0)] <- NA
D[which(D == 0)] <- NA

Using which here will cause undefined columns in A and D, thus causing the error message.

Could you please confirm and fix this?

Thanks,

Yilin