search

single-cell-genetics / cellsnp-lite

Efficient genotyping bi-allelic SNPs on single cells
https://cellsnp-lite.readthedocs.io
Apache License 2.0
124 stars 11 forks source link

Incorrect parameter passing causes segmentation fault #45

Open adbeggs opened 2 years ago

adbeggs commented 2 years ago

Hi

More of an observation that I don't read instructions properly but if you pass --minmaf instead of --minMAF to cellsnp-lite it dumps with a segmentation fault. Ditto for --minCOUNT

Makes it very difficult to understand what I was doing wrong!!

Thanks for a great bit of software otherwise

hxj5 commented 2 years ago

Thanks for your feedback. The segmentation fault was raised by the low-level function (getopt_long) used by cellsnp-lite, when given incorrect parameter. Now this issue has been fixed (commit 09ea9c3) and we will add the patch to the next release (in bioconda).