search

single-cell-genetics / cellsnp-lite

Efficient genotyping bi-allelic SNPs on single cells
https://cellsnp-lite.readthedocs.io
Apache License 2.0
132 stars 11 forks source link

-ldeflate is missing in Makefile after I executed ./configure #98

Open darkcircle opened 1 year ago

darkcircle commented 1 year ago

As we know, HTSlib source tree is also included during compilation process. HTSlib source tree also needs to refer libdeflate, but configure does not create Makefile containing LIBS="-ldeflate blabla ..." (refer Makefile line 243.)

so ... in line 33 to 35 of Makefile.am 

## xxx_LDADD is some additional libraries besides $LIBS which could collect
## the libraries added by AC_CHECK_LIB
cellsnp_lite_LDADD = @HTSLIB_LIB@

would better to be modified as below,

## xxx_LDADD is some additional libraries besides $LIBS which could collect
## the libraries added by AC_CHECK_LIB
cellsnp_lite_LDADD = @HTSLIB_LIB@ -ldeflate

so I solved compilation problem by fixing the automake script as above. How would you think about it?