Generate a root-config that includes single-spa-layout

single-spa / create-single-spa

https://single-spa.js.org/docs/create-single-spa

Other

131 stars 59 forks source link

Generate a root-config that includes single-spa-layout #141

Closed filoxo closed 4 years ago

filoxo commented 4 years ago

single-spa-layout is released as a beta
Documentation is complete for single-spa-layout
I think it would be good to include or at least add some commented code to show:
- Loading UIs when applications are downloaded.
- Default routes for Not Found / 404 pages.

For an example, see https://github.com/react-microfrontends/root-config/pull/11

This option should be clearly marked as "beta" when the user is prompted, as well as having multiple places with a link to open an issue/send feedback.

joeldenning commented 4 years ago

Yeah I've been thinking that if single-spa-layout's feedback is positive and we don't find any showstopper bugs that we'll want to start pushing it more. Putting it into single-spa-layout is a way of doing that. I had been thinking we'd wait until that time to put it into single-spa-layout as the default implementation, but like your idea too. Making it a user prompt option would be nice. 👍