Closed JuanRGil closed 4 years ago
Thanks for the bug report
This is a duplicate of https://github.com/single-spa/create-single-spa/issues/26 and https://github.com/react-microfrontends/root-config/pull/4. It will be fixed by #27
I'm closing as a duplicate
npm init single-spa of type "single-spa root config" generates some scripts in index.ejs file which does not work as expected . This is the code:
<% if (isLocal) { %>
When the varibale "isLocal" is set to false (in package.json) the behaviour does not change."start": "webpack-dev-server --mode=development --port 9001 --env.isLocal=false",
It consider that variable as a string and the result of :<% if ("some string including false") { %>
is true. It would be great if the script generated in package.json was:"start": "webpack-dev-server --mode=development --port 9001 --env.isLocal
instead of"start": "webpack-dev-server --mode=development --port 9001 --env.isLocal=true",
As it is confusing. If we dont want it to be local, we should only remove the argument "--env.isLocal""start": "webpack-dev-server --mode=development --port 9001