single-spa / create-single-spa

https://single-spa.js.org/docs/create-single-spa
Other
128 stars 60 forks source link

fix: upgrading fork-ts-checker-webpack-plugin version and configuration #364

Closed anthonysessa closed 1 year ago

anthonysessa commented 1 year ago

When linking a package, e.g. yalc, yarn link, etc., the fork-ts-checker-webpack-pluing does not rebuild TypeScript, so webpack-dev-server cannot find updated exports.

According to the documentation, when using mode: "write-references" the build flag should be set to true.

Use readonly if you don't want to write anything on the disk, write-dts to write only .d.ts files, write-tsbuildinfo to write only .tsbuildinfo files, write-references to write both .js and .d.ts files of project references (last 2 modes requires build: true).

Also updated fork-ts-checker-webpack-plugin to the latest release.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: ad5048bd795a7ca15a356b0a1a3aa78807a24149

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

anthonysessa commented 1 year ago

Wanted to ping @joeldenning @filoxo @TheMcMurder to get a review when possible