single-spa / create-single-spa

https://single-spa.js.org/docs/create-single-spa
Other
128 stars 60 forks source link

upgrade to babel-eslint@next #37

Closed joeldenning closed 4 years ago

joeldenning commented 4 years ago

Also, we need to specify that babel-eslint is the eslint parser in the following files:

TheMcMurder commented 4 years ago

Also, we need to specify that babel-eslint is the eslint parser in the following files:

* https://github.com/single-spa/create-single-spa/blob/master/packages/generator-single-spa/src/react/templates/.eslintrc

* https://github.com/single-spa/create-single-spa/blob/master/packages/generator-single-spa/src/root-config/templates/.eslintrc

* https://github.com/single-spa/create-single-spa/blob/master/packages/generator-single-spa/src/util-module/templates/.eslintrc

These files already seem to have "parser": "babel-eslint"

joeldenning commented 4 years ago

Oh then how did react-microfrontends not have it in its eslintrc??? Maybe it used an old version of create-single-spa?

joeldenning commented 4 years ago

This is resolved