Open bfoong-equinix opened 1 year ago
Latest commit: 42c0417869ffef2ac5eaa079ec77d32c8952128e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@joeldenning noticed you mentioned in another PR you are not actively maintaining anymore, which maintainer should we ping to get a review?
Looking through other closed PR's, I think @TheMcMurder might be the guy
thanks @gregorysl. @TheMcMurder are you able to review this PR?
Hi, this PR would require more work, specifically taking into account caveats mentioned in the esbuild-loader documentation:
Caveats esbuild only supports a subset of tsconfig options (see TransformOptions interface).
Enable isolatedModules to avoid mis-compilation with features like re-exporting types.
Enable esModuleInterop to make TypeScript's type system compatible with ESM imports.
Features that require type interpretation, such as emitDecoratorMetadata and declaration, are not supported.
I would recommend starting a discussion in the Slack's maintainers channel so we can discuss the implications.
Upgraded webpack's babel-loader into esbuild-loader to improve transpilation speed
Performance gain reference https://github.com/esbuild-kit/esbuild-loader/discussions/138