changeset-bot[bot]
commented
1 year ago 🦋 Changeset detected
Latest commit: 9e99f853ae9ab6772450d5c14de7d027174daf26
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
| Name | Type | | -------------------- | ----- | | generator-single-spa | Patch | | single-spa-welcome | Patch | | create-single-spa | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Fix for the problem described in issue https://github.com/single-spa/create-single-spa/issues/382
NOTE: When running the GitHub actions I had problems with the test step. The problem was that I was using a different version of pnpm on my local. I downgraded to the version previously used in the GitHub actions and could reproduce the problem. With that version of pnpm (6.29.1) my lock file was unstable and it changed when running tests. Also, the tests kept failing. By upgrading pnpm to the latest version (8.6.1) the tests run fine. Due to the update, I had to slightly adjust the commands in the GitHub workflow and add a dev dependency that was missing in the single-spa-welcome app. With these minor changes and adjustments, the GitHub actions workflow runs successfully in my local.