single-spa / create-single-spa

https://single-spa.js.org/docs/create-single-spa
Other
128 stars 60 forks source link

infra: reconfigure jest #402

Open MilanKovacic opened 3 months ago

MilanKovacic commented 3 months ago

Why has husky been removed?

Majority of CLI tools do not include husky configuration. This is mainly because most companies have their own existing infrastructure, and for beginners, it mostly confuses them. For a proper husky configuration we would also need to include lint-staged, which is why I recommend we remove it for now, and re-add it later if there is interest.

joeldenning commented 3 months ago

husky + pretty-quick is an alternative to lint-staged. I prefer pretty-quick because it doesn't require configuring all file extensions like lint-staged does (afaik)

This change removes husky without introducing lint-staged.

Perhaps we should change the scope of the PR to only include what is in the title - jest configuration - then a discussion and follow-up PR for husky or other changes?