single-spa / import-map-deployer

A manifest deployment service for sofe/import maps
Apache License 2.0
191 stars 63 forks source link

Preventing "" as a service key #120

Closed TheMcMurder closed 3 years ago

TheMcMurder commented 3 years ago

Due to an internal configuration error I discovered that import-map-deployer accepts "" as a valid key in PATCH requests at /services & /import-map.

After fixing the internal configuration error I thought it might be wise to prevent this behavior. I believe it's technically valid for an import-map to have a key of "", but I figured it still might be worth preventing.

joeldenning commented 3 years ago

Released in https://github.com/single-spa/import-map-deployer/releases/tag/v4.4.1