search

single-spa / import-map-deployer

A manifest deployment service for sofe/import maps
Apache License 2.0
191 stars 63 forks source link

Upgrade aws-sdk from 2.814.0 -> 2.1404.0 #158

Open ralphsaunders opened 1 year ago

ralphsaunders commented 1 year ago

We run Import Map Deployer in EKS and were trying to upgrade to v4.6.0 from the old version we were running (v2.2.1). When we upgraded we saw S3 permissions errors in the logs and import-map-deployer wasn't able to access buckets.

The yarn.lock specifies aws-sdk@2.814.0.

In the changelog for aws-sdk, there was a bugfix in 2.853.0 that should resolve this:

2.853.0

  • bugfix: s3: Bugfixing the s3 arn endpoint parser ...

This PR bumps the aws-sdk (and its dependency tree) to the latest v2 version.

$ yarn upgrade aws-sdk@^2
success Saved lockfile.
success Saved 13 new dependencies.
info Direct dependencies
└─ aws-sdk@2.1404.0
info All dependencies
├─ aws-sdk@2.1404.0
├─ get-intrinsic@1.2.1
├─ has-proto@1.0.1
├─ has-symbols@1.0.3
├─ has@1.0.3
├─ is-arguments@1.1.1
├─ is-callable@1.2.7
├─ is-generator-function@1.0.10
├─ is-typed-array@1.1.10
├─ jmespath@0.16.0
├─ util@0.12.5
├─ which-typed-array@1.1.9
└─ xml2js@0.5.0
✨  Done in 7.81s.
ralphsaunders commented 1 year ago

Looks like someone else ran into this issue in #146 and suggested the same solution.

Unfortunately, deploying a custom image of this PR to our EKS this morning, we verified this didn't solve the issue.

We did have success with downgrading to import-map-deployer#v3.0.0.