search

single-spa / single-spa-angular

Helpers for building single-spa applications which use Angular
Apache License 2.0
203 stars 78 forks source link

Trying to integrate angular9 application #287

Closed sanjanaadeshra closed 4 years ago

sanjanaadeshra commented 4 years ago

Trying to integrate angular9 application

Production Environment


Libs:
- @angular/core version:~9.1.7
- single-spa-angular version: ^4.0.1

I am trying to use an application built in angular 10. I am trying to include the build in main root-html application, but getting the following error, can you please help me out with it.

zone.js:192 Uncaught ReferenceError: global is not defined
    at Object.bBst (index.js:2)
    at __webpack_require__ (bootstrap:19)
joeldenning commented 4 years ago

Angular 10 isn't fully supported by single-spa-angular. The issue title here indicates you're using Angular 10, but the code snippet you shared indicates 9.1.7. Which version of Angular is this for?

sanjanaadeshra commented 4 years ago

With angular version 10 since compatibility was an issue, I've downgraded it down to 9.1.7, but still the same issue.

arturovt commented 4 years ago

@sanjanaadeshra can you provide a minimal reproducible example?

hervedevos commented 4 years ago

Angular 10 isn't fully supported by single-spa-angular. The issue title here indicates you're using Angular 10, but the code snippet you shared indicates 9.1.7. Which version of Angular is this for?

@joeldenning Can you detail what's missing ? I integrated an Angular 10 app and I didn't encounter any issues for now...

arturovt commented 4 years ago

@hervedevos this repository contains 5 Angular applications for integration purposes and they all use the latest Angular version (10.2.0). Joel probably meant the issue that was encountered this summer related to ng add command. Angular 10 is supported.

joeldenning commented 4 years ago

Joel probably meant the issue that was encountered this summer related to ng add command. Angular 10 is supported.

Yes @arturovt is right here - angular 10 is supported. When I last commented I wasn't sure if there were still problems with the schematics, but there are not.

integrated an Angular 10 app and I didn't encounter any issues for now...

Sounds like the issue is resolved here - closing this issue now.