arturovt
commented
9 months ago Why would you use the ng17 branch?
Closed arturovt closed 8 months ago
arturovt
commented
9 months ago Why would you use the ng17 branch?
Wushurui
commented
9 months ago @arturovt Because our project uses Angular17, but single-spa-angular has not yet released a version corresponding to Angular17, and I saw the commit you mentioned, so I want to try it with your ng17 branch. I would like to ask, is your commit about all the changes to upgrade to support angular17?
arturovt
commented
9 months ago The single-spa-angular is compatible with angular 17.
Wushurui
commented
9 months ago OK, thanks
b-ferrari
commented
8 months ago @arturovt - Is there anything I can do to help bump this merge along? I'm sure you're super busy, but this has been open for a few months now and I figured it wouldn't hurt to merge it in before angular 18 rolls around 😄
victorlevasseur
commented
8 months ago I added this #499 to solve the build issues preventing this PR from being buildable. Meanwhile, when our teams began migrating to Angular 17, we encountered issues with parcels and zone.js when navigating from/to microfrontends using Angular 17 (but the parcels are still Angular 14). I'll try to have an small example to try to replicate the issue.
roshaw
commented
7 months ago @arturovt I see that all changes about ng17 are inside the main branch. Is there a plan to relase npm version?
I got this error after I use the ng17 branch in my package.json: An unhandled exception occurred: Cannot find module 'single-spa-angular/libs/single-spa-angular/webpack' Require stack:
And here is my package.json: "dependencies": { "@angular-builders/custom-webpack": "^17.0.0", "@angular/animations": "^17.0.8", "@angular/cdk": "^17.0.4", "@angular/common": "^17.0.8", "@angular/compiler": "^17.0.8", "@angular/core": "^17.0.8", "@angular/forms": "^17.0.8", "@angular/platform-browser": "^17.0.8", "@angular/platform-browser-dynamic": "^17.0.8", "@angular/router": "^17.0.8", "@manulife-design/md": "^1.0.5", "file-saver": "^2.0.5", "numeral": "^2.0.6", "powerbi-client-angular": "^3.0.5", "rxjs": "~7.8.1", "single-spa": "^5.9.5", "single-spa-angular": "github:single-spa/single-spa-angular#ng17", "tslib": "^2.1.0", "xlsx": "^0.18.5", "zone.js": "^0.14.2" }, "devDependencies": { "@angular-devkit/build-angular": "^17.0.8", "@angular/cli": "^17.0.8", "@angular/compiler-cli": "^17.0.8", "@angular/language-service": "^17.0.8", "@types/file-saver": "^2.0.4", "@types/jasmine": "^4.3.5", "@types/jasminewd2": "~2.0.10", "@types/node": "~16.11.7", "codelyzer": "^6.0.2", "jasmine-core": "~4.6.0", "jasmine-spec-reporter": "~7.0.0", "karma": "~6.4.2", "karma-chrome-launcher": "~3.2.0", "karma-coverage-istanbul-reporter": "~3.0.3", "karma-jasmine": "^5.1.0", "karma-jasmine-html-reporter": "^2.0.0", "protractor": "~7.0.0", "sonar-scanner": "^3.1.0", "systemjs-webpack-interop": "^2.3.7", "ts-node": "~10.9.1", "tslint": "~6.1.3", "typescript": "^5.2.2", "webpack": "^5.88.2" }