single-spa / single-spa-examples

Examples of single-spa applications.
https://single-spa.surge.sh
MIT License
359 stars 128 forks source link

WIP: Implementing ember example #37

Closed joeldenning closed 7 years ago

joeldenning commented 7 years ago

This will fix #33

joeldenning commented 7 years ago

Thanks @acorncom and @dshrestha for the help. Here are the only things I know of that remain:

1) Create a helper library for using single-spa and ember. This would be similar to https://github.com/CanopyTax/single-spa-react and https://github.com/CanopyTax/single-spa-angular2 2) It would be nice to simplify loading the vendor and app bundles in some way. Either make them capable of being imported with SystemJS.import(), or write a reusable function that will create the script tags and wrap it in a promise.

joeldenning commented 7 years ago

@acorncom @dshrestha I just pushed another commit that uses the brand new helper library https://github.com/CanopyTax/single-spa-ember. Would you guys mind taking a look at single-spa ember and giving feedback on how it works and also the documentation for it?

Once that is done, I think we're ready to merge this pr in.