search

single-spa / single-spa-examples

Examples of single-spa applications.
https://single-spa.surge.sh
MIT License
359 stars 128 forks source link

Not working on Windows,.. #40

Closed webia1 closed 6 years ago

joeldenning commented 7 years ago

Could you provide the error message you saw in the command prompt? I know that these lines of code don't work in windows, but am curious if there is anything else (since I don't have a windows machine myself).

bhupendrajoshi commented 6 years ago

'.\bin\build-code' is not recognized as an internal or external command, operable program or batch file.

bhupendrajoshi commented 6 years ago

as a work around I prefixed all the ./bin/build* in the with bash, to run as bash command

like in package.json "build": "bash ./bin/build-code", instead of "build": "./bin/build-code",

did the same in ./bin/build-code

joeldenning commented 6 years ago

@bhupendrajoshi would you be able to pull request your changes? I meant to get around to this but haven't had the chance yet.

TheMcMurder commented 6 years ago

Prefixing the build instructions with bash will only work on windows if you have the command setup in the command prompt or are using the linux subsystem for windows. We'll need to change all of the build scripts to correctly work on Windows (without bash) and Unix based OS's

Taking a look at how other open source projects solve this:

  1. Python or other easy to install cross OS scripts (NodeJS)
  2. Use NodeJS instead of Bash (Enzyme)
joeldenning commented 6 years ago

@webia1 @bhupendrajoshi apologies for the slowness in fixing -- it should be fixed now. I changed all bash scripts to be cross platform node scripts. Let me know if you run into any more problems.