search

single-spa / single-spa-examples

Examples of single-spa applications.
https://single-spa.surge.sh
MIT License
359 stars 128 forks source link

fix side nav that doesn't display #61

Closed joshalling closed 5 years ago

joshalling commented 6 years ago

This PR fixes the side nav on small screen sizes. I don't know much about materialize, but I'm assuming that the side nav init function only works if your target list is a direct child of one of the parents of the toggle button. I moved the list outside of the Dialog component and it works now.

I'm not sure if this will have some unintended side effects as I am not very familiar with this project and I don't know all of the reasons behind using the Dialog component, but I did test it locally and everything seems to be working.

see #60

joeldenning commented 5 years ago

lgtm - apologies for the slow response