search

single-spa / single-spa-inspector

A devtools extension for single-spa applications
https://single-spa.js.org
MIT License
76 stars 17 forks source link

Overlays are no longer colored by a generated value from their names #44

Closed TheMcMurder closed 4 years ago

TheMcMurder commented 4 years ago

From: https://single-spa.js.org/docs/devtools

  color: "#000", // the default for this is actually based on the app's name, so it's dynamic. can be a hex or a CSS color name

background: "#000", // the default for this is actually based on the app's name, so it's dynamic. can be a hex or a CSS color name

These seem to always be black here: https://react.microfrontends.app/people

filoxo commented 4 years ago

I'm taking a look at this today. I'm testing just getColorFromString (https://github.com/single-spa/single-spa-inspector/blob/236ba825994a5010d21c17dd92c30146f5c97cdb/src/inspected-window-helpers/overlay-helpers.js#L132) and it works correctly except if the app name contains a @. Whenever that character is present, it returns that black color.