search

single-spa / single-spa-layout

Layout engine for single-spa applications
MIT License
78 stars 31 forks source link

fix: adjust and replace types for use with new release parse5 #173

Closed cristofersousa closed 1 year ago

cristofersousa commented 2 years ago

ISSUE: https://github.com/single-spa/single-spa-layout/issues/172

Resolves:

I was having trouble building with TS, because of the new versions of the parse5 library. Because of this, it was suggested to make the adjustment to reflect the new scenario, basically what was done:

Links

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48402/files#diff-107d402a30275251354f4d0116a2942b4b0631205531ad5ee46c602108ab1836R111

PS: This is my first pull request, any misconduct in the creation please let me know so I can adjust and follow the appropriate team standard.

cristofersousa commented 2 years ago

@joeldenning @filoxo could you help me with this code review

timglenn123 commented 1 year ago

Hi I am receiving this error as well. Will this update be merged and released anytime soon? 

node_modules/single-spa-layout/dist/types/isomorphic/constructRoutes.d.ts:74:81 - error TS2694: Namespace '"/Users/Developer/Workspace/root/node_modules/parse5/dist/index"' has no exported member 'DefaultTreeDocument'.

74 export type RoutesConfig = InputRoutesConfigObject | Element | import('parse5').DefaultTreeDocument | string;
joeldenning commented 1 year ago

Released in https://github.com/single-spa/single-spa-layout/releases/tag/v2.2.0