search

single-spa / single-spa-layout

Layout engine for single-spa applications
MIT License
78 stars 31 forks source link

Modify routing event handling to do nothing if navigation is cancelled #200

Closed jfcartkeep closed 11 months ago

jfcartkeep commented 1 year ago

Fix the same problem found in #190 but with the previous major version. Currently, this fix is only present in the new 2.x version which depends on the latest beta for single-spa (currently 6.0.0-beta3). Updating to this version is technically not a problem but this can a problem for project which don't use betas.

I understand that the beta is deemed stable but the "beta" state in the version name and the fact that this beta is older then the newest 5.x version can scare a lot of people.

MilanKovacic commented 11 months ago

@joeldenning This is a backport of #190. Looks good to merge.

joeldenning commented 11 months ago

published in single-spa-layout@1.6.1. It's under the version-1 npm tag