search

single-spa / single-spa-layout

Layout engine for single-spa applications
MIT License
78 stars 31 forks source link

Loading UI is not working #84

Closed kush1995ptl closed 4 years ago

kush1995ptl commented 4 years ago

Hi, loading UI is not working. I did same code provided in single spa layout documentation. I have attached screenshot for the same. It it giving the error app died.

problem1 problem2 problem3
joeldenning commented 4 years ago

Hi @kush1995ptl, I tried out loading states in the react-microfrontends example and was unable to reproduce this issue. The loading UIs showed when the navbar failed to load, and when it loaded.

Could you confirm that you're using the latest version of single-spa-layout in your root config? The latest is 1.1.2: https://github.com/single-spa/single-spa-layout/releases/tag/v1.1.2

joeldenning commented 4 years ago

Also, you can see loading states working by going to https://react.microfrontends.app/ and throttling your network connection in the chrome devtools so that the loading state stays around longer.

One thing to note is that it is expected and normal for loading UIs to disappear when an application fails to load. If you're wanting to show a UI when the application fails to load and mount, you should use Error UIs instead of loading UIs. See https://single-spa.js.org/docs/layout-definition#error-uis

joeldenning commented 4 years ago

I'm closing this issue since I think that this is likely a misunderstanding of the behavior of Loading UIs (that they disappear after the application fails to load). Feel free to comment further or reopen.