search

single-spa / single-spa-playground

A website that helps you set up single-spa
http://single-spa-playground.org
MIT License
39 stars 10 forks source link

Automatically set up import map override for react / react dom #18

Closed joeldenning closed 4 years ago

joeldenning commented 4 years ago

Create-single-spa users should not have to manually create overrides for react, react-dom, Vue, Vue-router, etc when testing out their new repo.

TheMcMurder commented 4 years ago

Are you thinking to just put all of those in the import map, Or allow configuration somehow?

joeldenning commented 4 years ago

I think just throwing a bunch of dependencies into the import map below might be fine. Other option would be to provide a query param to the instant-test route, but I don't think that provides much value over just always having it there:

https://github.com/single-spa/single-spa-playground/blob/5449e5c5b8319cc7c43bdcbfb7a2178163ba315e/index.html#L13-L20

joeldenning commented 4 years ago

Resolved in https://github.com/single-spa/single-spa-playground/pull/21