single-spa / single-spa-playground

A website that helps you set up single-spa
http://single-spa-playground.org
MIT License
39 stars 10 forks source link

Bumping dependencies #19

Closed Sauloxd closed 4 years ago

Sauloxd commented 4 years ago

Hi All! :) I've been talking to @joeldenning and as the start for my open source contributions, I'm helping to do some chores on this repo! I don't know the best way to bump dependencies, but I've used yarn upgrade-interactive --latest, I wonder if there's a better way?

My testing routine:

Important notes

Bumping husky to @4 comes with a node requirement of >= 10 (and Git >= 2.13.0) Maybe it's better to add node@>=10 as the engine on package.json?

frehner commented 4 years ago

Looks good to me.

I think adding the engines field to package.json is a good idea too. Do you mind adding that?

joeldenning commented 4 years ago

Thanks for your work on this - yes, upgrading to the latest packages is the right thing to do when we can. I usually use yarn upgrade-interactive --latest.

Could you also upgrade the dependencies in https://github.com/single-spa/single-spa-playground/blob/master/index.html and https://github.com/single-spa/single-spa-playground/blob/master/src/html-file/html-file.component.js to their latest versions?

Sauloxd commented 4 years ago

Updates: