Improved user flow - Githubissues

single-spa / single-spa-playground

A website that helps you set up single-spa

http://single-spa-playground.org

MIT License

39 stars 10 forks source link

Improved user flow #24

Closed Sauloxd closed 4 years ago

Sauloxd commented 4 years ago

As we talked, I improved the verification step to add a "check app has dependencies"! Also, I removed and refactored all that was not being used!

Will provide a deployed app so you can test again, but If possible, you can already start checking the code out!

Sauloxd commented 4 years ago

Here is a new version of this PR: https://even-room.surge.sh

Improved copies
Tried to make import map be generated by analysing the dependencies in given JS bundle.
Improves some errors types explanations:
- If user inputs invalid name from create-single-spa, systemjs-webpack-interop error will appear, and now it gives an instruction to user fix this
- if user has some System.import() inside the single-spa application, it will break in runtime (with "unable to find bare specifier" error), but now this step is covered by attaching errorHandling in singleSPA during runtime execution step

Sauloxd commented 4 years ago

@joeldenning updated this PR with your suggestions, and replied to some comments! [New app to test]((https://back-prose.surge.sh)

Thanks for always carefully reviewing my PR, this one is quite big, and I'm starting to lose track myself of what's going on! hahaha Hopefully this will help more users to use single-spa! Also, thanks for correcting my broken english 👍 I need to work on that too eheheh

Sauloxd commented 4 years ago

Updated:

Update with suggested copies
Remove delete button when editing registered app

new app link: https://ubiquitous-frogs.surge.sh/