search

single-spa / single-spa-playground

A website that helps you set up single-spa
http://single-spa-playground.org
MIT License
39 stars 10 forks source link

Prevent instant-test from rerendering hundreds of times #28

Closed filoxo closed 4 years ago

filoxo commented 4 years ago

I found this performance issue when building the instant-test functionality for Angular. The effect that runs to set the application using the URL params is running hundreds of times.

Screen Shot 2020-06-02 at 3 45 41 PM

This causes significant slowness when testing the application. This fix makes it so that the effect is run only once.

Screen Shot 2020-06-02 at 3 47 10 PM