search

single-spa / single-spa-react

Single-spa lifecycles helper for React applications
https://single-spa.js.org/docs/ecosystem-react.html
MIT License
227 stars 63 forks source link

fix: define package.json export #168

Closed darshkpatel closed 1 year ago

darshkpatel commented 1 year ago

compiling a react application using a rollup based plugin (@vitejs/plugin-react in my case) will throw an error if package.json isn't exported.

The only package failing in my usecase is single-spa-react I did test this change by manually adding this line to the package in the node_modules folder and compiling again.

Example of such a export: https://github.com/facebook/react/blob/16d053d592673dd5565d85109f259371b23f87e8/packages/react-refresh/package.json#L24 Related issue on another repo: https://github.com/uuidjs/uuid/issues/444

Fixes: #140

courtyenn commented 1 year ago

I tried this fix and it didn't work for me. I instead deleted the "exports" config and fixed my own type issues within my project it worked.

Edit** I went in and compiled single-spa-react on its own and it seemed to work. Idk

joeldenning commented 1 year ago

@darshkpatel do you know the solution to this typescript problem?

https://github.com/single-spa/single-spa-react/pull/173

darshkpatel commented 1 year ago

I’ll investigate

On Wed, 28 Jun 2023 at 5:12 AM, Joel Denning @.***> wrote:

@darshkpatel https://github.com/darshkpatel do you know the solution to this typescript problem?

168 https://github.com/single-spa/single-spa-react/pull/168

— Reply to this email directly, view it on GitHub https://github.com/single-spa/single-spa-react/pull/168#issuecomment-1610366288, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACV4TLSH5EMA2APT642Q7ZTXNNVXDANCNFSM6AAAAAAXYW3A7I . You are receiving this because you were mentioned.Message ID: @.***>