search

single-spa / single-spa-react

Single-spa lifecycles helper for React applications
https://single-spa.js.org/docs/ecosystem-react.html
MIT License
227 stars 63 forks source link

Swap L51 and L50 #198

Closed SeverS closed 1 year ago

SeverS commented 1 year ago

Fixes #157 by swapping the lines L51 with L50.

Minimal repro repository: https://github.com/SeverS/single-spa-react-repro gh-pages : https://severs.github.io/single-spa-react-repro/

As you can see on gh-pages, the Button parcel works as expected when it's mounted inline but when you click it the modal which is using appendTo throws an error (check console)

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 6241131d1e5b7c2161167ab49d2e9491c2702df3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR