search

single-spa / single-spa-react

Single-spa lifecycles helper for React applications
https://single-spa.js.org/docs/ecosystem-react.html
MIT License
227 stars 63 forks source link

fix parcel appendTo #199

Open SeverS opened 1 year ago

SeverS commented 1 year ago

Hi, This pr fixes #157 by swapping the lines L50 with L51 in parcel.js

Minimal repro repository: https://github.com/SeverS/single-spa-react-repro gh-pages: https://severs.github.io/single-spa-react-repro/

As you can see on gh-pages the button parcel works as expected when inline but when you click it it will throw an error in the console and the 'modal' parcel will never be mounted.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: f0d249525123b02edea695c710e984a6dd2cfcf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | single-spa-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

SeverS commented 1 year ago

gm @MilanKovacic , can you help me adding the reviewers to this pr? thanks a lot!

MilanKovacic commented 1 year ago

Hi, thank you for submitting the pull request. I will take a look. While waiting for the release, I recommend using https://www.npmjs.com/package/patch-package.