search

single-spa / single-spa-react

Single-spa lifecycles helper for React applications
https://single-spa.js.org/docs/ecosystem-react.html
MIT License
227 stars 63 forks source link

Fixed an issue with mounting a parcel when StrictMode is enabled #206

Closed nickbosland closed 2 months ago

nickbosland commented 9 months ago

StrictMode in React 18 renders a component an extra time where the component is unmounted and mounted again. This sets the unmounted value to true which prevent to component from actually mounting.

Fixes #160

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: cf6b87dceb1fd269546baadb853473186233d8f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | single-spa-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lipsumar commented 6 months ago

We are anxiously waiting for this PR to land. We've tested it and it seems to work fine.

MilanKovacic commented 6 months ago

I will take a look.

aaronbates commented 6 months ago

Hi @MilanKovacic did you get a chance to take a look? We'd very much appreciate it!

aaronbates commented 6 months ago

Thank you @MilanKovacic — appreciated.

@nickbosland if you get chance to take a look at the feedback that would be great, or equally we'd be happy to submit a PR if you're short on time. Thanks all

aaronbates commented 6 months ago

@nickbosland are you OK to merge this if you have rights? TY

lipsumar commented 5 months ago

@MilanKovacic what are the next steps to get this released ?

MilanKovacic commented 5 months ago

It is waiting for approval from Joel.