single-spa / single-spa-svelte

a single-spa plugin for svelte applications
Apache License 2.0
20 stars 3 forks source link

No documentation for new update prop as well as a bug #19

Open northkode opened 2 years ago

northkode commented 2 years ago

I think there is a bug with 2.1.1 version.

The singleSpaProps object that is online 49 is null.. and the chooseDomElementGetter function passing in opts and singleSpaProps but if singleSpaProps == null the code completely dies and crashes the app

image

image

This should be optional and default to a blank {} object then line 92 - 97 would run for backwards compatibility image