single-spa / single-spa.js.org

https://single-spa.js.org/
108 stars 234 forks source link

Ember Docs seem outdated? #425

Open stephencweiss opened 3 years ago

stephencweiss commented 3 years ago

The docs related to using single-spa-ember suggest that ember-cli requires bower:

First, since the ember cli only supports dependencies from bower, you'll need to do:

bower init bower install single-spa-ember --save

However, per the updated Ember docs, this appears to be outdated:

When you're using dependencies that are not included in an addon, you will have to instruct Ember CLI to include your assets in the build. This is done using the asset manifest file ember-cli-build.js. You should only try to import assets located in the node_modules and vendor folders. bower_components also still works, but is recommended against, unless you have no other choice. Even bower recommends not to use itself anymore.

I would make a PR on the docs themselves, but honestly, I'm not sure what the right answer is as I'm still trying to make sense of how all this works.

filoxo commented 3 years ago

A community member recently published this tutorial which might contain a much more up-to-date approach: https://dev.to/rajasegar/ember-micro-frontends-with-single-spa-1p8j We'd definitely appreciate any contributions on this since the core team only has superficial experience with Ember.

So far, its been my experience that single-spa-ember is used largely just to migrate off of Ember, not to maintain multiple Ember applications (see also https://github.com/single-spa/create-single-spa/issues/268#issuecomment-791037636)/) so it might also be good to keep these older instructions somehow for those that are looking to migrate a legacy Ember app.

stephencweiss commented 3 years ago

its been my experience that single-spa-ember is used largely just to migrate off of Ember

That's exactly what we're trying to do 😄 ! But I need a bridge to get there and I'm hoping to leverage single-spa for that purpose.