search

single-spa / single-spa.js.org

https://single-spa.js.org/
108 stars 234 forks source link

JP/single-spa-react #600

Closed webJose closed 10 months ago

webJose commented 1 year ago

Update example for React versions lower than v18.

webJose commented 1 year ago

Here are some screenshots of the changes. Apologies, I was test driving the GitHub PR extension in VS Code. It works nicely, but I could not add these shots in the original message.

image

image

joeldenning commented 10 months ago

I think we should fix latest single-spa-react to work with React 17, rather than update the documentation for it. See https://github.com/single-spa/single-spa-react/issues/202

joeldenning commented 10 months ago

This documentation change is no longer necessary, due to the fix in single-spa-react@6.0.1

https://github.com/single-spa/single-spa-react/releases/tag/v6.0.1