search

single-spa / standalone-single-spa-webpack-plugin

A webpack plugin for running microfrontends in standalone mode.
MIT License
42 stars 8 forks source link

Yarn 2, webpack 5. #5

Closed joeldenning closed 3 years ago

joeldenning commented 3 years ago

In webpack 4, you specify webpack env vars via --env.varName. In webpack 5, it's --env varName. This change updates the language in the html file to be correct depending on which version of webpack you're using. I also added yarn 2 - from what I've heard this will still work for yarn 1 users after it's merged

joeldenning commented 3 years ago

Thanks for your review - i didn't know that about safeRequire. Will update.

joeldenning commented 3 years ago

I've updated this with your feedback.