search

single-spa / vue-cli-plugin-single-spa

https://single-spa.js.org/docs/ecosystem-vue.html#vue-cli
21 stars 11 forks source link

Fix file-loader public path #13

Closed joeldenning closed 4 years ago

joeldenning commented 4 years ago

Vue CLI overrides file-loader's default public path, which makes image urls incorrectly resolve relative to the page instead of relative to the dynamic public path.

joeldenning commented 4 years ago

See the following links:

https://single-spa.slack.com/archives/CGGUQJMK6/p1596558697206800

https://single-spa.slack.com/archives/CGGUQJMK6/p1596560634215600

https://cli.vuejs.org/guide/html-and-static-assets.html#static-assets-handling

https://cli.vuejs.org/guide/html-and-static-assets.html#the-public-folder

joeldenning commented 4 years ago

This isn't a problem and already works. We thought it was an issue because set-public-path.js was not at the top of the entry file.