search

singlebrook / utf8-cleaner

MIT License
277 stars 44 forks source link

Remove Rails 5 / Rack deprecation warning #28

Closed benlovell closed 8 years ago

benlovell commented 8 years ago

Rails 5 / Rack 2 issues a deprecation warning when attempting to modify the middleware stack with a string-enclosed middleware constant.

benlovell commented 8 years ago

Hmm. listen / guard dropped support for end-of-life Rubies so won't build unless we pin at an earlier, compatible version or also follow suit and drop support for < 2.2 over here.

sbleon commented 8 years ago

listen and guard are only for development, so pinning them won’t affect end-users, only developers and Travis. I’m fine with pinning them in order to keep a broad build matrix. Go for it!

On Fri, May 20, 2016 at 11:29 AM, Ben Lovell notifications@github.com wrote:

Hmm. listen / guard dropped support for end-of-life Rubies so won't build unless we pin at an earlier, compatible version or also follow suit and drop support for < 2.2 over here.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/singlebrook/utf8-cleaner/pull/28#issuecomment-220638134

sbleon commented 8 years ago

Released in v0.2.4. Thanks!

benlovell commented 8 years ago

Thanks ❤️