singlebrook / utf8-cleaner

MIT License
277 stars 44 forks source link

Removing warnings for URI.decode because these method is now obsolete #38

Closed benjamin-ltr closed 4 years ago

benjamin-ltr commented 4 years ago

Hi! I am currently trying ruby 2.7.0 on my rails app and I get this deprecation warning:

~/.rvm/gems/ruby-2.7.0/gems/utf8-cleaner-0.2.5/lib/utf8-cleaner/uri_string.rb:90: warning: URI.unescape is obsolete

This is basically a fix for that deprecation warning.

Let me know if you think we can do better.

Thanks

sbleon commented 4 years ago

Thanks, Benjamin! The warning is gone and the tests pass, so this looks good!.

sbleon commented 4 years ago

Released as v1.0.0!

benjamin-ltr commented 4 years ago

Awesome, thanks