search

singlelink-co / Singlelink

The open-source Linktree alternative.
https://singlelink.co
GNU General Public License v3.0
556 stars 117 forks source link

Basic linktree import functionality #183

Closed benkaiser closed 3 years ago

benkaiser commented 3 years ago

This includes the setup changes PR, but we can undo those changes to keep this PR standalone.

This PR addresses #178

Current implementation simply brings across the raw links. In a future PR we could extend this functionality to also import:

Screen recording of experience:

LinktreeImport

NavidK0 commented 3 years ago

This looks great! We can definitely integrate this, but I would like to figure out why Monaco isn't working. Perhaps @jimmybisenius can chime in here since he implemented the plugin in the first place. I'm fairly certain it's used for the in-app code editors.

NavidK0 commented 3 years ago

@benkaiser Can you try these steps for me? Make sure you have the Monaco editor code uncommented.

Run: 1) Delete .nuxt and node_modules 2) Open a terminal and set your necessary env variables 3) npm run dev

It should work then, including the Monaco editor. I'm having a hard time reproducing the error, unfortunately

NavidK0 commented 3 years ago

LGTM.

benkaiser commented 3 years ago

Awesome, thanks @NavidK0 !

The Monaco editor thing is definitely just a node version issue, running node 16.5 fixed it (the docker container was 16.3, so that was my hint)

NavidK0 commented 3 years ago

Thanks for your contribution, this was a great one! Good to know that node 16 is a requirement, didn't realize it before. We'll be sure to get that documented.

jimmybisenius commented 3 years ago

@benkaiser, just seeing this now.... this is AWESOME. so excited to get this in production 🔥

Thank you for taking the time to make a PR!

benkaiser commented 3 years ago

No worries @jimmybisenius , thinks for looking at the issue and being so prompt to follow up! Was a great experience contributing to the project