singlestore-labs / singlestoredb-laravel-driver

The official SingleStore Laravel driver.
https://github.com/singlestore-labs/singlestore-laravel-driver
Apache License 2.0
223 stars 22 forks source link

Add empty Sort Key support #36

Closed miguilimzero closed 2 years ago

miguilimzero commented 2 years ago

This pull request implements support for empty sort key definition. This kind of feature applies when the developer wants to set custom column store variables without setting a column as a sort key.

Example:

Schema::create('table', function (Blueprint $table) {
    $table->string('name');

    $table->sortKey()->with(['columnstore_segment_rows' => 100000]);
});
miguilimzero commented 2 years ago

@carlsverre I noticed the README still contains info about saying the package is a pre-release beta. Was the warning forgotten there or is it still valid? The package seems solid to me :)

carlsverre commented 2 years ago

This is awesome @srdante. Thanks for the PR!

And good call, I will start the process of marking it as "production ready".