search

singlestore-labs / singlestoredb-laravel-driver

The official SingleStore Laravel driver.
https://github.com/singlestore-labs/singlestore-laravel-driver
Apache License 2.0
223 stars 22 forks source link

Changed definitions of overridden functions to match the original #49

Closed AdalbertMemSQL closed 1 year ago

AdalbertMemSQL commented 1 year ago

In https://github.com/singlestore-labs/singlestoredb-laravel-driver/pull/46/ I overrode 4 functions of the MySqlGrammar and added a return type to the definition. Occurred that this is a breaking change as all users that extended from our class and overridden the same functions - also should add the return type.

carlsverre commented 1 year ago

I'll land and ship this now. But in parallel is it possible to add some tests to ensure we don't break this in the future?