singnet / ai-dsl

Artificial Intelligence Domain Specific Language (AI-DSL) to enable autonomous interoperability between AI services.
MIT License
70 stars 18 forks source link

A simple fake News classifier implemented on idris #13

Closed Eman22S closed 3 years ago

Eman22S commented 3 years ago

This branch contains an implementation of Neural Networks, activation functions, loss functions specifically, Softmax activation layer, Cross entropy loss function and Adam optimization done from scratch in Idris. There is also a haskel version to this classifier not pushed. Testing on the the accuracy of prediction as well as conversion of csv files directly using idris is not yet implemented.

ngeiswei commented 3 years ago

Very cool, @Eman22S!

I'll carefully review that tomorrow, meanwhile could you

  1. move that code to experimental/ai-algorithms
  2. remove the following files
    experimental/NeuralNets/*.ibc
    experimental/NeuralNets/build/*
    experimental/NeuralNets/util.idr

    followed by clean force push? Thanks.

Eman22S commented 3 years ago

@ngeiswei Yes definitely we don't need those build files

ngeiswei commented 3 years ago

@Eman22S, could you

  1. rebase your branch onto the master,
  2. move your NeuralNets folder under experimental/ai-algorithms,
  3. then push to another branch than master,
  4. close that PR and recreate a new one with that branch? Thanks.
Eman22S commented 3 years ago

@Nil thank you for your reviews I will work on them and send a new PR after a rebase.

ngeiswei commented 3 years ago

Comment syntax, --, |||, etc, is described here

http://docs.idris-lang.org/en/latest/reference/documenting.html

It's for idris1 but is still valid for idris2.