search

singnet / ai-dsl

Artificial Intelligence Domain Specific Language (AI-DSL) to enable autonomous interoperability between AI services.
MIT License
70 stars 18 forks source link

Sam report #49

Closed sroberti closed 3 years ago

ngeiswei commented 3 years ago

Thanks @sroberti, very appreciated. Could you in a subsequent PR include your code on the nomadic approach and reference it in the report?

ngeiswei commented 3 years ago

@sroberti, could you rebase your PR onto the master, there's something odd, like it has 34 pages while the master has 43 pages. I suspect, based on the diff, that merging it will go just fine (maybe I'll try that local) but just in case, maybe you can rebase instead, then either force push on that same branch or create a new PR.

ngeiswei commented 3 years ago

Never mind, @sroberti, it works fine locally so I'm merging. In the future, my recommendation is when you have a long branch that hasn't been shared yet (no PR yet) you can rebase onto the master before creating a PR, that results into a cleaner history.