search

singnet / asmoses

Port of MOSES (https://github.com/opencog/moses) for the AtomSpace (https://github.com/opencog/atomspace)
Other
6 stars 5 forks source link

Fix ASMOSESUTest for failing simple_regression problem #119

Closed Eman22S closed 4 years ago

ngeiswei commented 4 years ago

I think that looks good @Eman22S, thanks. @kasimebrahim, does that look good to you too?

Eman22S commented 4 years ago

@kasimebrahim Yes, we can sure remove extract_output_size (I must have forgotten to remove it) because it is not computing the output_size correctly i.e it had some implementation flaws. its better we pass the output_size directly .

ngeiswei commented 4 years ago

@kasimebrahim, can I leave it to you to merge, if you determine it is ready? Thanks.

ngeiswei commented 4 years ago

@kasimebrahim @Eman22S do you remember if that one is ready for merging?