search

singnet / asmoses

Port of MOSES (https://github.com/opencog/moses) for the AtomSpace (https://github.com/opencog/atomspace)
Other
6 stars 5 forks source link

Feature selection should support contin features #142

Open ngeiswei opened 3 years ago

ngeiswei commented 3 years ago

Calling asmoses on a trivial boolean table with feature selection enabled crashes

 asmoses -Hit -i input.csv --enable-fs=1
terminate called after throwing an instance of 'opencog::AssertionException'
  what():  Type boolean is not supported for mutual information (/home/nilg/OpenCog/asmoses/opencog/data/table/table.h:1486)
Aborted (core dumped)

Where input.csv is the following

a,b,c,out
0,0,3.0,0
0,1,0.0,0
1,0,1.0,0
1,1,1.0,1
ngeiswei commented 3 years ago

Oh, I just noticed that c is a numerical feature, that might be the reason of the crash. Then the only thing that might be wrong is the assertion (or assertion message). Obviously, passed that, it would be good if feature selection support numerical features that would be for another issue.

ngeiswei commented 3 years ago

An extremely easy first step, albeit limited, would be to add contin feature selection support for the random algorithm (see --fs-algo).