search

singnet / asmoses

Port of MOSES (https://github.com/opencog/moses) for the AtomSpace (https://github.com/opencog/atomspace)
Other
6 stars 5 forks source link

ASMOSESUTest fails #86

Open stellarspot opened 5 years ago

stellarspot commented 5 years ago

The failed ASMOSESUTest:

In ASMOSESUTest::test_atomese_sr_3:
/ws/as-moses/tests/moses/main/ASMOSESUTest.cxxtest:100: Error: Test failed: unsupported (/ws/as-moses/opencog/combo/converter/combo_atomese.cc:142)
Failed 1 and Skipped 0 of 13 tests

It prints that the builtin parameter in the std::pair<Type, Handle> vertex_2_atom::operator()(const builtin &b) const method is exp.

ngeiswei commented 5 years ago

That's "normal", should be fixed within the next few days.

vsbogd commented 5 years ago

@ngeiswei, am I right that problem is that builtin::exp is not wrapped by atom yet? May be disable test then?

ngeiswei commented 5 years ago

exp is now supported and it passes locally, but circleci seems to be the problem.

vsbogd commented 5 years ago

For me it doesn't pass locally.

Bitseat commented 5 years ago

Since the solution is not merged yet, it is failing as a result of unsupported functions in your case.

vsbogd commented 5 years ago

@Bitseat , thanks, so am I right that in current singnet/asmoses master it is not supported? If so should we just disable testcase until fix is merged?

Bitseat commented 5 years ago

yes you are right @vsbogd . test_atomese_sr_3() tests many of the ported asmoses units so we were trying so hard to have a full support of it instead of disabling it. But if is to much of a problem I guess disabling it for a while is a good idea.

ngeiswei commented 5 years ago

Or maybe we can just merge https://github.com/singnet/asmoses/pull/89 ? Though then it will pass locally but might still not pass on circleci for a reason we still don't understand.

vsbogd commented 5 years ago

Ah ok, so fix is raised as #89 , I didn't get it at the beginning. Yes, I see that locally test passes. It is strange that in CircleCI it fails with SIGSEGV.