singnet / das

1 stars 0 forks source link

integration test failure #64

Closed mjsduncan closed 1 month ago

mjsduncan commented 1 month ago

following the README integration test

../das-query-engine$ git branch -vv
* master c108236 [origin/master] Merge pull request singnet/das-query-engine#293 from singnet/angelo/bug/#62/better-msg-about-unsupported-python-version

(hyperon-das-py3.10) .../das-query-engine$ make integration-tests
==================================================== test session starts ====================================================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /home/mozi/.cache/pypoetry/virtualenvs/hyperon-das-mpMqY1xH-py3.10/bin/python
cachedir: .pytest_cache
rootdir: /media/mozi/7361de95-66da-41ce-8d3d-d05196c633a1/hyperon/das-query-engine
configfile: pytest.ini
plugins: cov-4.1.0
collected 42 items                                                                                                          
...
...
tests/integration/test_local_das.py::TestLocalDASRedisMongo::test_queries FAILED

========================================================= FAILURES ==========================================================
____________________________________________ TestLocalDASRedisMongo.test_queries ____________________________________________

self = <tests.integration.test_local_das.TestLocalDASRedisMongo object at 0x777266e1b130>

    def test_queries(self):
        _db_up()
        das = DistributedAtomSpace(
            query_engine='local',
            atomdb='redis_mongo',
            mongo_port=mongo_port,
            mongo_username='dbadmin',
            mongo_password='dassecret',
            redis_port=redis_port,
            redis_cluster=False,
            redis_ssl=False,
        )
>       assert das.count_atoms() == {'atom_count': 0}

tests/integration/test_local_das.py:27: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
hyperon_das/das.py:440: in count_atoms
    return self.query_engine.count_atoms(parameters)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <hyperon_das.query_engines.local_query_engine.LocalQueryEngine object at 0x777266f0b310>, parameters = None

    def count_atoms(self, parameters: Optional[Dict[str, Any]] = None) -> Dict[str, int]:
        if parameters and parameters.get('context') == 'remote':
            return {}
>       return self.local_backend.count_atoms(parameters)
E       TypeError: RedisMongoDB.count_atoms() takes 1 positional argument but 2 were given

hyperon_das/query_engines/local_query_engine.py:297: TypeError
================================================== short test summary info ==================================================
FAILED tests/integration/test_local_das.py::TestLocalDASRedisMongo::test_queries - TypeError: RedisMongoDB.count_atoms() takes 1 positional argument but 2 were given
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
==================================== 1 failed, 29 passed, 2 skipped in 84.38s (0:01:24) =====================================
make: *** [Makefile:19: integration-tests] Error 1
levisingularity commented 1 month ago

@mjsduncan this problem might be related to this one https://github.com/singnet/das/issues/60. Can you please test it as well?

mjsduncan commented 1 month ago

this was also fixed, all tests are passing now, thanks!