singnet / snet-rfai-dapp

MIT License
1 stars 10 forks source link

Can't submit a request for 1 AGI with 1 AGI in escrow (bug) #32

Closed rustam-RI closed 5 years ago

rustam-RI commented 5 years ago

Testing Environment:

Windows 10, Google Chrome 73.0.3683.86 (64bit), 15.6", 1920х1080

Precondition:

User has 1 AGI on escrow balance

Steps to reproduce:

  1. Navigate to Home Page of RFAI
  2. Press "Create" button in the right upper corner of the screen
  3. Navigate to the "Submit Request" in opened window
  4. Fill all fields like on the video below (the main point is that you should type 1 in the "Initial Funding Amount" field)
  5. Press "Submit"
  6. Observe the result

EXPECTED RESULT:

System has submitted the request

ACTUAL RESULT:

User sees such an error message "Oops! You dont have enough token balance in RFAI Escrow."

Note:

I suppose the reason can be related to the situation when user tries to deposit exactly as much AGI tokens as he / she has. Because when I had set 0,5 AGI as a funding amount and pressed "Submit" once more I got another error message with such a text "Oops! Invalid Github handle."

Please see the video below

20190405_20h33_25

ksridharbabuus commented 5 years ago

Fixed the issue. It might caused by the number limits on git API calls. Now changed the git call only onBlur rather than every call.

Issue is fixed.

rustam-RI commented 5 years ago

Fix is verified, thanks