singnet / snet-rfai-dapp

MIT License
1 stars 10 forks source link

Can't open pages for "Create", "Account" and "View Requests" options in new tabs (bug) - #35

Closed rustam-RI closed 5 years ago

rustam-RI commented 5 years ago

Testing Environment:

Windows 10, Google Chrome 73.0.3683.86 (64bit), 15.6", 1920х1080

Steps to reproduce:

  1. Navigate to Home Page of RFAI
  2. Try to open "Create" page in new tab (using "Create" button)
  3. Try to open "Account" page in new tab (using "Account" button)
  4. Try to open "View Requests" page in new tab (using "View Requests" button)
  5. Observe the result

EXPECTED RESULT:

We can see three tabs

ACTUAL RESULT:

Please see the video below

20190408_04h55_16

ksridharbabuus commented 5 years ago

That is as per the expected behaviour. Those needs to be opened in the current browser instance. If this functionality is needed we can enable the same and I dont this it is required for now.

rustam-RI commented 5 years ago

Well, on the one hand I am not sure that it's critical to provide such functionality asap indeed but on the other hand it doesn't really look as nice user experience that we show user the same Home Page in case of trying to open specific options (Create, Account etc) in the other tab. So I still think that it's better to make it possible to open "Create", "Account" and "View Requests" in the other tab.

ksridharbabuus commented 5 years ago

Added this functionality by adding Routes in the ReactJS SPA App.

Issue is fixed.

rustam-RI commented 5 years ago

Fix is verified, thanks.