search

singnet / snet-rfai-dapp

MIT License
1 stars 10 forks source link

System takes AGI from the Escrow Balance but doesn't submit the request (Critical Bug) - #40

Open rustam-RI opened 5 years ago

rustam-RI commented 5 years ago

Testing Environment:

Windows 10, Google Chrome 73.0.3683.86 (64bit), 15.6", 1920х1080

Precondition:

User has 9 AGI on Escrow Balance

Steps to reproduce:

  1. Navigate to Home Page of RFAI
  2. Press "Create New Request" button
  3. Wait until "Create Request" page wouldn't appear
  4. Navigate to the "Submit Request" tab
  5. Fill all fields (you can see my test data on the video)
  6. Submit the request

EXPECTED RESULT:

Request has been successfully submitted

ACTUAL RESULT:

System took 7 AGI which user wanted to use for funding from the Escrow Balance but haven't submitted the request even after successful transaction. When I pressed "Submit" button once again I saw such an error message

"Oops! You dont have enough token balance in RFAI Escrow."

Please see the video below

20190408_08h30_40

ksridharbabuus commented 5 years ago

Once the request is created will be available for the Approval. Only Approved requests will be visible in the Active Tab. I can see the request with 7 AGI tokens created when I logged in with Foundation Member. image

rustam-RI commented 5 years ago

Thanks for explanation @ksridharbabuus. But then

  1. The user should be redirected to some page which will inform him / her that the request has been successfully submitted but it's on approval now.
  2. Also it can be better to inform the user about further steps. For example, inform the user when he / she can expect an approval / rejection of the request approximately or keep in touch with user in some other way.

The first point is about a bug which needs to be fixed and the second one is rather an enhancement but also pretty important one.

ksridharbabuus commented 5 years ago

It is clearly explained in the process flow mentioned in the separate tabs.

rustam-RI commented 5 years ago

Explanation is ok but it's a common practice to take user away from the last page and show him / her some info message after the end of the process like submitting the solution / placing the order / etc.

rustam-RI commented 5 years ago

Just in case: I am still sure that it's a critical bug which should be fixed.

Blockspaced commented 5 years ago

@rustam-snet this is not a critical bug: the request was submitted, but it will only be published once a Foundation member (someone from SNET) approves it to be listed into the RFAI portal. @ksridharbabuus I suggest that this can be an enhancement instead, where the user is prompted with a successful submission message once he completes the submission.