search

singnet / snet-rfai-dapp

MIT License
1 stars 10 forks source link

Why "Close project" button is disabled? (question) - #44

Closed rustam-RI closed 5 years ago

rustam-RI commented 5 years ago

Right now "Close project" button is disabled for all active requests. Do I understand it right that "Close project" button is only available for the user who requested the service? Also is it defined by comparison of the wallet address of requestor and wallet address of current user?

ksridharbabuus commented 5 years ago

Only based on the role the Close Button is Enabled. For instance only Foundation Member can use the Close Button.

rustam-RI commented 5 years ago

Thanks for the answer @ksridharbabuus. Then can you please clarify how does the system defines the role of the person which currently uses the website? I mean how RFAI platform knows which roles do current user have?

ksridharbabuus commented 5 years ago

There are only three roles, one as a Foundation Member and other is a regular user. Foundation members are controlled by the administrator who is the owner of the contract.

rustam-RI commented 5 years ago

Hmm, I try to understand how to test the functional fully and to be honest it's still not clear for me how the system knows the role of the user. I can understand that some administrator can assign role to users but here we connect to the platform through the MetaMask instead of some "sign in" process so do the roles are assigned to specific ETH addresses? Also it would be good if I will be able to test the "Close project" option as a Foundation Member, maybe the administrator can give me that role for the test?

ksridharbabuus commented 5 years ago

Foundation Member role is an internal role only to approve the requests. And remaining all users will be normal users. Foundation Members are managed by the Admin (Owner of the Contract). This is the standard way we do it in Smart Contracts.

ksridharbabuus commented 5 years ago

@rustam-snet You can refer the RFAI Smart Contract repository for the requirements @ https://github.com/singnet/snet-rfai

Please let me know if you need any additional details.

Blockspaced commented 5 years ago

@ksridharbabuus since this button is not used by regular users, what do you think about hiding it for them?

ksridharbabuus commented 5 years ago

This gives an indication that the project can be closed. If you recommend to hide the button yes we can do that. Please let me know your thoughts.

On Thu, Apr 25, 2019 at 1:47 AM smbss notifications@github.com wrote:

@ksridharbabuus https://github.com/ksridharbabuus since this button is not used by regular users, what do you think about hiding it for them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486408929, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYVNXA6EFGBERTND3JVRDDPSC55TANCNFSM4HEZVZ2A .

-- Thanks, Sri Blog: http://sridharbabuk.blogspot.com/

Blockspaced commented 5 years ago

I think that this should be done with the use of a label instead of a button that only works for certain types of users.

Sridhar Babu Kolapalli notifications@github.com escreveu no dia quinta, 25/04/2019 à(s) 05:18:

This gives an indication that the project can be closed. If you recommend to hide the button yes we can do that. Please let me know your thoughts.

On Thu, Apr 25, 2019 at 1:47 AM smbss notifications@github.com wrote:

@ksridharbabuus https://github.com/ksridharbabuus since this button is not used by regular users, what do you think about hiding it for them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486408929 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABYVNXA6EFGBERTND3JVRDDPSC55TANCNFSM4HEZVZ2A

.

-- Thanks, Sri Blog: http://sridharbabuk.blogspot.com/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486514125, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRMP27BQGRH5KWHVFZHSITPSEWJ3ANCNFSM4HEZVZ2A .

ksridharbabuus commented 5 years ago

Thanks. Let me discuss with UI team and will implement accordingly.

On Thu, Apr 25, 2019 at 7:19 PM smbss notifications@github.com wrote:

I think that this should be done with the use of a label instead of a button that only works for certain types of users.

Sridhar Babu Kolapalli notifications@github.com escreveu no dia quinta, 25/04/2019 à(s) 05:18:

This gives an indication that the project can be closed. If you recommend to hide the button yes we can do that. Please let me know your thoughts.

On Thu, Apr 25, 2019 at 1:47 AM smbss notifications@github.com wrote:

@ksridharbabuus https://github.com/ksridharbabuus since this button is not used by regular users, what do you think about hiding it for them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486408929

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABYVNXA6EFGBERTND3JVRDDPSC55TANCNFSM4HEZVZ2A

.

-- Thanks, Sri Blog: http://sridharbabuk.blogspot.com/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486514125 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADRMP27BQGRH5KWHVFZHSITPSEWJ3ANCNFSM4HEZVZ2A

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/singnet/snet-rfai-dapp/issues/44#issuecomment-486680573, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYVNXBDCVUIDFANAAI3I4TPSGZHJANCNFSM4HEZVZ2A .

-- Thanks, Sri Blog: http://sridharbabuk.blogspot.com/